This repository has been archived by the owner on Sep 9, 2020. It is now read-only.
internal/gps: fix case mismatch error with multiple dependers #1233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
Previously, errors like the following could occur: v0.4.2: Could not introduce github.com/sirupsen/logrus due to a case-only variation: it depends on "github.com/Sirupsen/logrus", but "github.com/evalphobia/logrus_sentry@v0.4.2" was already established as the case variant for that project root by the following other dependers: (root) github.com/docker/docker@8510adf8c856d6f0871650216a0e1d7e6ece46ee This fix matches the correct behavior when there is only one depender earlier in the function.
glasser
force-pushed
the
glasser/case-mismatch-error
branch
from
94e05f1
to
681e6f5
Compare
|
CLAs look good, thanks! |
|
Resubmitted with the email address that has a CLA. |
|
yes yes, thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do / why do we need it?
Fixes a bad error message added in dep 0.3.1.
Previously, errors like the following could occur:
v0.4.2: Could not introduce github.com/sirupsen/logrus due to a case-only variation: it depends on "github.com/Sirupsen/logrus", but "github.com/evalphobia/logrus_sentry@v0.4.2" was already established as the case variant for that project root by the following other dependers:
(root)
github.com/docker/docker@8510adf8c856d6f0871650216a0e1d7e6ece46ee
This fix matches the correct behavior when there is only one depender earlier in
the function.
What should your reviewer look out for in this PR?
Is there an opportunity to add a test for this? I didn't see one.
Do you need help or clarification on anything?
No
Which issue(s) does this PR fix?
I didn't file an issue but I did jot down a comment on the PR that introduced this issue: #1079 (comment)